Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance the example sample apps to prevent unnecessary errors #101

Merged
merged 4 commits into from Nov 11, 2020
Merged

Enhance the example sample apps to prevent unnecessary errors #101

merged 4 commits into from Nov 11, 2020

Conversation

mxiamxia
Copy link
Member

@mxiamxia mxiamxia commented Nov 10, 2020 •
edited

Description:
Enhance the docker compose example.

  • Make the sample app as pure Web App. It only generates Metrics and Traces data when the web APIs are called
  • Add a traffic emitter which keeps calling the sample app APIs for Metrics and Traces data

** Sample App Link **

Testing:
Tested on local laptop

@mxiamxia mxiamxia changed the title split sample app and traffic generator to mimic the prod behavior Enhance the example sample apps to prevent unnecessary errors Nov 10, 2020
@mxiamxia mxiamxia merged commit 2e32e7f into aws-observability:main Nov 11, 2020
JasonXZLiu pushed a commit to open-o11y/aws-otel-collector that referenced this pull request Nov 19, 2020
@hossain-rayhan
ecs-metrics: update expected template with new dimension names (aws-o…
7abcdce 
…bservability#101)

Signed-off-by: Rayhan Hossain <hossain.rayhan@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyTrivail wyTrivail wyTrivail approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mxiamxia @wyTrivail