fix the new breaking zap logger hook #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hossain-rayhan
approved these changes
Nov 18, 2020
Codecov Report
@@ Coverage Diff @@
## main #135 +/- ##
=======================================
Coverage 76.05% 76.05%
=======================================
Files 4 4
Lines 71 71
=======================================
Hits 54 54
Misses 9 9
Partials 8 8 Continue to review full report at Codecov.
|
wyTrivail
approved these changes
Nov 18, 2020
vastin
pushed a commit
to vastin/aws-otel-collector
that referenced
this pull request
Mar 3, 2021
…y#135) * use data mode as dimension * change otlp mock to trace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: <Describe what has changed.
Upstream updated the zap logger hook parameter. updated to accommodate the change.
Testing:
Tested logging function in local