Changed OTLP default port to 4317. #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
approved these changes
Feb 10, 2021
mxiamxia
reviewed
Feb 10, 2021
config.yaml
Outdated
| http: | ||
| endpoint: 0.0.0.0:55681 | ||
| endpoint: 0.0.0.0:4318 |
There was a problem hiding this comment.
It's weird the upstream haven't changed the default port for http protocol yet - https://github.com/open-telemetry/opentelemetry-collector/blob/main/receiver/otlpreceiver/factory.go#L43
There was a problem hiding this comment.
@mxiamxia It is a good catch. There is an open issue for splitting ports of OTLP receiver. I updated this PR to only change 55680 to 4317 for OTLP/gRPC before the issue is resolved in upstream.
open-telemetry/opentelemetry-collector#1256
wyTrivail
approved these changes
Feb 10, 2021
mxiamxia
approved these changes
Feb 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Update with new OTLP default port number changed in following commit.
open-telemetry/opentelemetry-specification@4dd4ee0d
There is dependent pull request. Please don't merge this PR before following PR get merged.
aws-observability/aws-otel-test-framework#234
Link to tracking Issue:
#345
Testing:
local mock test