chore: use os.Chown instead of calling chown command #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use os.Chown instead of calling chown command when changing ownership of the aoc config files. Also fix the aoc running user to be `aoc` since the environment override is not very useful but create more complicated use cases.
Codecov Report
@@ Coverage Diff @@
## main #524 +/- ##
===========================================
- Coverage 82.60% 61.45% -21.16%
===========================================
Files 6 8 +2
Lines 115 179 +64
===========================================
+ Hits 95 110 +15
- Misses 11 54 +43
- Partials 9 15 +6
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Use os.Chown instead of calling chown command when changing ownership of
the aoc config files. This would improve the future portability of the code.
Also fix the aoc running user to be
aocsince the environment override is notvery useful but create more complicated use cases.
Testing:
Unit test added and tested locally
Documentation:
No documentation change needed since no behavior change are expected.