Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed name limitations #725

Merged
merged 4 commits into from
Nov 11, 2021
Merged

fixed name limitations #725

merged 4 commits into from
Nov 11, 2021

Conversation

rltoSD
Copy link
Contributor

@rltoSD rltoSD commented Nov 9, 2021

Description: Fixing a parameter; exceeded 32 char limit

Testing: tested by deploying on ecs

@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2021

Codecov Report

Merging #725 (b882537) into main (457a1b0) will not change coverage.
The diff coverage is n/a.

❗ Current head b882537 differs from pull request most recent head 7bc592f. Consider uploading reports for the commit 7bc592f to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #725   +/-   ##
=======================================
  Coverage   54.69%   54.69%           
=======================================
  Files          11       11           
  Lines         298      298           
=======================================
  Hits          163      163           
  Misses        118      118           
  Partials       17       17           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 457a1b0...7bc592f. Read the comment docs.

@jefchien
Copy link
Member

You're one commit behind of main. Please rebase.

Copy link
Contributor

@alolita alolita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change names to ecs-cwci-xray.yaml and ecs-cwci.yaml - the current names don't work.

@jefchien jefchien merged commit 0018053 into aws-observability:main Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants