Fix config environment variable expansion for AOT_CONFIG_CONTENT #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefchien
force-pushed
the
748-fix-config-env-var-expand
branch
from
366fab5
to
d672d44
Compare
aateeqi
approved these changes
Dec 2, 2021
Aneurysm9
approved these changes
Dec 2, 2021
sethAmazon
approved these changes
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: The configurations provided by
AOT_CONFIG_CONTENTwere not expanding their environment variables. It appears that this was factored out of the config unmarshalling in the upstream as part of v0.37.0. Wrapped theNewInMemoryprovider in theNewExpandprovider to expand the environment variables.Link to tracking Issue: #748
Testing: Added environment variable expansion tests to
config_factory_test.go