enable people to build image with dockerfile directly #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #89 +/- ##
=======================================
Coverage 75.36% 75.36%
=======================================
Files 4 4
Lines 69 69
=======================================
Hits 52 52
Misses 9 9
Partials 8 8 Continue to review full report at Codecov.
|
anuraaga
approved these changes
Nov 3, 2020
mxiamxia
reviewed
Nov 3, 2020
| COPY go.mod /workspace/go.mod | ||
| COPY go.sum /workspace/go.sum | ||
| COPY VERSION /workspace/VERSION | ||
| COPY .git /workspace/.git |
There was a problem hiding this comment.
yes, it's needed, we need .git to get latest commit hash, version to get version
mxiamxia
approved these changes
Nov 3, 2020
JasonXZLiu
pushed a commit
to open-o11y/aws-otel-collector
that referenced
this pull request
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Modify the dockerfile, so that people can directly use it to build image with building binary in front.
Testing:
Tested on local