Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

speed up the docker build #93

Merged
merged 1 commit into from Nov 4, 2020
Merged

speed up the docker build #93

merged 1 commit into from Nov 4, 2020

Conversation

wyTrivail
Copy link
Contributor

Description:

Speed up the docker build,

  1. use go mod download to cache the downloading libs.
  2. just build amd64 binary in docker.

Testing:

Manually tested. reduce the time from 25 minutes to 14 minutes

@codecov-io
Copy link

Codecov Report

Merging #93 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #93   +/-   ##
=======================================
  Coverage   75.71%   75.71%           
=======================================
  Files           4        4           
  Lines          70       70           
=======================================
  Hits           53       53           
  Misses          9        9           
  Partials        8        8           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e0c7a6...3c98839. Read the comment docs.

@wyTrivail wyTrivail merged commit 926ab60 into main Nov 4, 2020
@wyTrivail wyTrivail deleted the dockerbuild branch November 4, 2020 03:32
JasonXZLiu pushed a commit to open-o11y/aws-otel-collector that referenced this pull request Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants