Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for OTEL_PROPAGATORS other than awsxray #109

Closed
michaelhyatt opened this issue Jul 5, 2021 · 1 comment · Fixed by #110
Closed

Support for OTEL_PROPAGATORS other than awsxray #109

michaelhyatt opened this issue Jul 5, 2021 · 1 comment · Fixed by #110
Assignees

Comments

@michaelhyatt
Copy link

Is your feature request related to a problem? Please describe.
At the moment, Python lambdas only support AWS-XRay trace propagation. Setting OTEL_PROPAGATORS environment variable to anything than awsxray is ignored.

Describe the solution you'd like
Support for other context propagators, such as W3C and B3 by setting OTEL_PROPAGATORS=tracecontext, for example.

Describe alternatives you've considered
I managed to get it to work with tracecontext by cloning the otel-instrumentation script, adding environ["OTEL_PROPAGATORS"] = "tracecontext" and setting AWS_LAMBDA_EXEC_WRAPPER env variable to it.

@anuraaga
Copy link
Contributor

anuraaga commented Jul 5, 2021

Thanks @michaelhyatt - agree that we should check for the presence of the variable before overwriting it like we do in other languages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants