fix: Remove error flag from x-ray trace root. (#211)

aws-observability · Aug 18, 2022 · b71aaa9 · b71aaa9
1 parent 12c4568
commit b71aaa9
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 5 deletions.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -2,9 +2,9 @@ name: AWS RUM Web Client Continuous Build
 
 on:
     push:
-        branches: [main]
+        branches: [main, release-*.*.*]
     pull_request:
-        branches: [main]
+        branches: [main, release-*.*.*]
 
 concurrency:
     group: ${{ github.workflow }}-${{ github.ref }}

diff --git a/src/plugins/event-plugins/FetchPlugin.ts b/src/plugins/event-plugins/FetchPlugin.ts
@@ -151,7 +151,6 @@ export class FetchPlugin extends MonkeyPatched<Window, 'fetch'> {
                     xRayTraceEvent.throttle = true;
                 } else if (is4xx(response.status)) {
                     xRayTraceEvent.subsegments[0].error = true;
-                    xRayTraceEvent.error = true;
                 } else if (is5xx(response.status)) {
                     xRayTraceEvent.subsegments[0].fault = true;
                     xRayTraceEvent.fault = true;

diff --git a/src/plugins/event-plugins/XhrPlugin.ts b/src/plugins/event-plugins/XhrPlugin.ts
@@ -150,7 +150,6 @@ export class XhrPlugin extends MonkeyPatched<XMLHttpRequest, 'send' | 'open'> {
                 xhrDetails.trace.throttle = true;
             } else if (is4xx(xhr.status)) {
                 xhrDetails.trace.subsegments[0].error = true;
-                xhrDetails.trace.error = true;
             } else if (is5xx(xhr.status)) {
                 xhrDetails.trace.subsegments[0].fault = true;
                 xhrDetails.trace.fault = true;

diff --git a/src/plugins/event-plugins/__tests__/FetchPlugin.test.ts b/src/plugins/event-plugins/__tests__/FetchPlugin.test.ts
@@ -290,7 +290,6 @@ describe('FetchPlugin tests', () => {
 
         // Assert
         expect(record.mock.calls[0][1]).toMatchObject({
-            error: true,
             subsegments: [
                 {
                     error: true,