Skip to content

Commit

Permalink
fix: Update version during release workflow only (#359)
Browse files Browse the repository at this point in the history
  • Loading branch information
qhanam committed Feb 24, 2023
1 parent 0150cdc commit f6b7bd7
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 5 deletions.
File renamed without changes.
6 changes: 6 additions & 0 deletions .github/workflows/cd.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,12 @@ jobs:
restore-keys: |
${{ runner.os }}-node-
- name: Update Version
id: update-version
run: |
chmod u+x .github/scripts/update-version.sh
.github/scripts/update-version.sh
- name: Build Release
run: |
npm ci
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,6 @@ jobs:
- name: Run Linter
run: npm run lint:errors

- name: Update version.json
run: npm run build:version

- name: Run Unit Tests
run: npm run test

Expand Down
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,3 @@ tests_output
logs
.idea
app/smoke_local.html
version.json
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"build:dist:es": "tsc --project ./tsconfig.es.json",
"build:dist:cjs": "tsc --project ./tsconfig.cjs.json",
"build:assets": "npm-run-all -p build:dist:* build:webpack:prod",
"build": "npm-run-all -s build:schemas build:version build:assets",
"build": "npm-run-all -s build:schemas build:assets",
"build:dev": "npm-run-all -s build build:webpack:dev",
"build:version": "bash update-version.sh",
"release": "npm run build",
Expand Down
3 changes: 3 additions & 0 deletions version.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"version": "0.0.0"
}

0 comments on commit f6b7bd7

Please sign in to comment.