Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix MonkeyPatch type arg. #222

Merged
merged 1 commit into from
Sep 8, 2022

Conversation

qhanam
Copy link
Member

@qhanam qhanam commented Sep 8, 2022

An incorrect type argument is causing some builds to fail because of a TypeScript error.

This change fixes the TypeScript error and resolves #218

Note that enabling TypeScript strict mode (i.e., "strict": true in tsconfig.js) made the error visible. I don't know why this error isn't visible without strict mode. I did try bumping the TypeScript version.

Issues like this could be prevented by #12.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Member

@adebayor123 adebayor123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@qhanam qhanam merged commit 3218294 into aws-observability:main Sep 8, 2022
@qhanam qhanam deleted the fix-xhr-plugin-type-def branch September 8, 2022 05:27
limhjgrace pushed a commit that referenced this pull request Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect type definition for methods in XhrPlugin
2 participants