Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): Start S3 Docs #278

Merged
merged 4 commits into from
May 17, 2023
Merged

feat(docs): Start S3 Docs #278

merged 4 commits into from
May 17, 2023

Conversation

sthulb
Copy link
Contributor

@sthulb sthulb commented May 17, 2023

Please provide the issue number

Issue number:

Summary

Adds S3 docs uploader to workflows

Changes

Adds AWS credentials gathering and uploads to an S3 bucket

Please provide a summary of what's being changed

User experience

Please share what the user experience looks like before and after this change

Docs will be available on docs.powertools.aws.dev

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@auto-assign auto-assign bot requested a review from hjgraca May 17, 2023 11:04
@github-actions github-actions bot added the feature New features or minor changes label May 17, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: +62.54 🎉

Comparison is base (63778f0) 0.00% compared to head (b588b21) 62.54%.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #278       +/-   ##
============================================
+ Coverage         0   62.54%   +62.54%     
============================================
  Files            0       61       +61     
  Lines            0     2627     +2627     
============================================
+ Hits             0     1643     +1643     
- Misses           0      984      +984     
Flag Coverage Δ
unittests 62.54% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 61 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sthulb sthulb merged commit 632165e into develop May 17, 2023
4 checks passed
@sthulb sthulb deleted the s3-docs branch May 17, 2023 11:38
@hjgraca hjgraca mentioned this pull request May 17, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New features or minor changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants