Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docs): doc and readme updates #301

Merged
merged 12 commits into from
Jun 20, 2023
Merged

chore(docs): doc and readme updates #301

merged 12 commits into from
Jun 20, 2023

Conversation

sliedig
Copy link
Contributor

@sliedig sliedig commented Jun 18, 2023

Please provide the issue number

Issue number:
#285

Summary

Updates to docs and readme addressing dotnet cli corrections, updates to idempotency location, link updates to new organisation.

Changes

Please provide a summary of what's being changed

User experience

Please share what the user experience looks like before and after this change

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

sliedig
sliedig commented Jun 18, 2023
View reviewed changes
mkdocs.yml Show resolved Hide resolved
@sliedig sliedig requested a review from hjgraca June 18, 2023 15:48
@sliedig sliedig added the do-not-merge PRs that are blocked for varying reasons label Jun 18, 2023
@hjgraca hjgraca requested a review from a team as a code owner June 19, 2023 11:54
hjgraca
hjgraca reviewed Jun 19, 2023
View reviewed changes
CODEOWNERS Outdated Show resolved Hide resolved
hjgraca
hjgraca reviewed Jun 19, 2023
View reviewed changes
docs/index.md Outdated Show resolved Hide resolved
hjgraca
hjgraca reviewed Jun 19, 2023
View reviewed changes
docs/we_made_this.md Outdated Show resolved Hide resolved
hjgraca
hjgraca requested changes Jun 19, 2023
View reviewed changes
Copy link
Contributor

@hjgraca hjgraca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete CODEOWNERS and url changes

@hjgraca hjgraca added the documentation Improvements or additions to documentation label Jun 19, 2023
@hjgraca hjgraca linked an issue Jun 19, 2023 that may be closed by this pull request
Docs: Error in nuget add package commands for dotnet sample #297
Closed
1 task
@hjgraca hjgraca mentioned this pull request Jun 19, 2023
Closed
1 task
@hjgraca hjgraca linked an issue Jun 20, 2023 that may be closed by this pull request
Docs: Incorrect formating in main README #295
Closed
1 task
hjgraca
hjgraca approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@hjgraca hjgraca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed changes to @sliedig branch

@hjgraca hjgraca removed the do-not-merge PRs that are blocked for varying reasons label Jun 20, 2023
@hjgraca hjgraca merged commit f0b7475 into aws-powertools:develop Jun 20, 2023
3 checks passed
@github-actions github-actions bot added the internal Maintenance changes label Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjgraca hjgraca hjgraca approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation internal Maintenance changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: Error in nuget add package commands for dotnet sample Docs: Incorrect formating in main README
2 participants
@sliedig @hjgraca