fix #1500 (#1506)

aws-powertools · Nov 8, 2023 · 0f3e896 · 0f3e896
1 parent 7918d9a
commit 0f3e896
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 2 deletions.
diff --git a/powertools-metrics/src/main/java/software/amazon/lambda/powertools/metrics/MetricsUtils.java b/powertools-metrics/src/main/java/software/amazon/lambda/powertools/metrics/MetricsUtils.java
@@ -178,8 +178,12 @@ private static void captureRequestAndTraceId(MetricsLogger metricsLogger) {
 
     private static String defaultNameSpace() {
         MetricsContext context = MetricsLoggerHelper.metricsContext();
-        return "aws-embedded-metrics".equals(context.getNamespace()) ?
-                SystemWrapper.getenv("POWERTOOLS_METRICS_NAMESPACE") : context.getNamespace();
+        if ("aws-embedded-metrics".equals(context.getNamespace())) {
+            String namespace = SystemWrapper.getenv("POWERTOOLS_METRICS_NAMESPACE");
+            return namespace != null ? namespace : "aws-embedded-metrics";
+        } else {
+            return context.getNamespace();
+        }
     }
 
     private static Optional<String> awsRequestId() {

diff --git a/...ls-metrics/src/test/java/software/amazon/lambda/powertools/metrics/MetricsLoggerTest.java b/...ls-metrics/src/test/java/software/amazon/lambda/powertools/metrics/MetricsLoggerTest.java
@@ -112,6 +112,37 @@ void singleMetricsCaptureUtility() {
                                 .containsEntry("Dimension1", "Value1")
                                 .containsKey("_aws")
                                 .containsEntry("xray_trace_id", "1-5759e988-bd862e3fe1be46a994272793");
+
+                        Map<String, Object> aws = (Map<String, Object>) logAsJson.get("_aws");
+
+                        assertThat(aws.get("CloudWatchMetrics"))
+                                .asString()
+                                .contains("Namespace=test");
+                    });
+        }
+    }
+
+    @Test
+    void singleMetricsCaptureUtilityWithNullNamespace() {
+        try (MockedStatic<SystemWrapper> mocked = mockStatic(SystemWrapper.class);
+             MockedStatic<software.amazon.lambda.powertools.core.internal.SystemWrapper> internalWrapper = mockStatic(
+                     software.amazon.lambda.powertools.core.internal.SystemWrapper.class)) {
+            mocked.when(() -> SystemWrapper.getenv("AWS_EMF_ENVIRONMENT")).thenReturn("Lambda");
+            // POWERTOOLS_METRICS_NAMESPACE is not defined
+
+            MetricsUtils.withSingleMetric("Metric1", 1, Unit.COUNT,
+                    metricsLogger -> metricsLogger.setDimensions(DimensionSet.of("Dimension1", "Value1")));
+
+            assertThat(out.toString())
+                    .satisfies(s ->
+                    {
+                        Map<String, Object> logAsJson = readAsJson(s);
+
+                        Map<String, Object> aws = (Map<String, Object>) logAsJson.get("_aws");
+
+                        assertThat(aws.get("CloudWatchMetrics"))
+                                .asString()
+                                .contains("Namespace=aws-embedded-metrics");
                     });
         }
     }