Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integration with CloudWatch ServiceLens #88 #111

Merged
merged 2 commits into from
Sep 25, 2020

Conversation

rb2010
Copy link
Contributor

@rb2010 rb2010 commented Sep 25, 2020

Issue #, if available:

Description of changes:

Closes #88

Integration with CloudWatch ServiceLens:
The xray_trace_id key is added to log output when tracing is active. This enables the log correlation functionality in ServiceLens to work with applications using powertools.

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@pankajagrawal16 pankajagrawal16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks neat. Few suggestions.

@pankajagrawal16
Copy link
Contributor

Also please update commit and pr title to match semantics before merge 🙂

@pankajagrawal16 pankajagrawal16 changed the title Integration with CloudWatch ServiceLens #88 feat: integration with CloudWatch ServiceLens #88 Sep 25, 2020
@pankajagrawal16 pankajagrawal16 merged commit 8001e72 into master Sep 25, 2020
@pankajagrawal16 pankajagrawal16 deleted the servicelens branch September 25, 2020 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration with CloudWatch ServiceLens
3 participants