Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Adding external examples from AWS SAM CLI App Templates #1318

Merged
merged 2 commits into from
Jul 27, 2023

Conversation

AlexeySoshin
Copy link
Contributor

Issue #, if available:

#1278

Description of changes:

Adding external templates updates in the AWS SAM CLI App Templates repo to the Examples Readme

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@scottgerring scottgerring changed the title Adding external examples from AWS SAM CLI App Templates docs: Adding external examples from AWS SAM CLI App Templates Jul 26, 2023
Copy link
Contributor

@scottgerring scottgerring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Holding off merging until #1316 is merged

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (baa3592) 79.65% compared to head (9dbc79d) 79.65%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1318   +/-   ##
=========================================
  Coverage     79.65%   79.65%           
  Complexity      639      639           
=========================================
  Files            73       73           
  Lines          2345     2345           
  Branches        253      253           
=========================================
  Hits           1868     1868           
  Misses          397      397           
  Partials         80       80           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Jul 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@scottgerring scottgerring merged commit 0671bbe into aws-powertools:main Jul 27, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants