Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix link to SQS large message migration guide #1422

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Conversation

scottgerring
Copy link
Contributor

@scottgerring scottgerring commented Sep 7, 2023

Issue #, if available:
n/a

Description of changes:

Fix a link in the documentation in the old SQS module guide. Have confirmed there are no other floating references to localhost in the docs tree. We should fire a docs deploy once this is merged.

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@jeromevdl jeromevdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oups, lgtm

@sonarcloud
Copy link

sonarcloud bot commented Sep 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@scottgerring scottgerring marked this pull request as ready for review September 11, 2023 14:46
@scottgerring scottgerring merged commit 18294af into main Sep 11, 2023
5 checks passed
@scottgerring scottgerring deleted the docs-fix-link branch September 11, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants