Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(v2): Add redis implementation to idempotency #1561

Draft
wants to merge 19 commits into
base: v2
Choose a base branch
from

Conversation

scottgerring
Copy link
Contributor

Issue #, if available:
#1504

Description of changes:

The remaining changes to add an alternative redis implementation to our newly-split idempotency module for v2. The previous split happened in #1559 .

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@scottgerring
Copy link
Contributor Author

@eldimi , I picked the remaining commits across from your old branch on top of v2, following on from the merge of the split itself.

There's some noise in here - changes in bits that you wouldn't have touched - but before I push commits to clean it up, let's chat when you are back from holidays 💪

Copy link

sonarcloud bot commented Feb 15, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
3.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants