Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom segment names #221

Merged
merged 1 commit into from
Dec 14, 2020

Conversation

volomas
Copy link
Contributor

@volomas volomas commented Dec 10, 2020

  • add segmentName attribute to Trace annotation
  • if segmentName is provided, use it as subsegment name instead of traced
    method's name

Issue #, if available:

Description of changes:

Checklist

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

* add segmentName attribute to Trace annotation
* if segmentName is provided, use it as subsegment name intead of traced
method's name
Copy link
Contributor

@pankajagrawal16 pankajagrawal16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change @Skipua . Looks good

@pankajagrawal16 pankajagrawal16 merged commit 2d0e08e into aws-powertools:master Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants