Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: logger-Remove custom keys interface #395

Merged
merged 2 commits into from May 14, 2021
Merged

feat: logger-Remove custom keys interface #395

merged 2 commits into from May 14, 2021

Conversation

pankajagrawal16
Copy link
Contributor

@pankajagrawal16 pankajagrawal16 commented May 14, 2021 •
edited

Issue #, if available: #394

closes #394

Description of changes:

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pankajagrawal16 pankajagrawal16 self-assigned this May 14, 2021
msailes
msailes approved these changes May 14, 2021
View reviewed changes
Copy link
Contributor

@msailes msailes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pankajagrawal16 pankajagrawal16 merged commit 70a57bf into master May 14, 2021
@pankajagrawal16 pankajagrawal16 deleted the feat-logger-remove-custom-key-util branch May 14, 2021 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msailes msailes msailes approved these changes

Assignees

@pankajagrawal16 pankajagrawal16

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to remove custom key from logger via LoggingUtils
2 participants
@pankajagrawal16 @msailes