Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add description where to find the layer arn #145

Merged
merged 2 commits into from
Aug 29, 2020
Merged

docs: add description where to find the layer arn #145

merged 2 commits into from
Aug 29, 2020

Conversation

am29d
Copy link
Contributor

@am29d am29d commented Aug 28, 2020

Issue #, if available:

Description of changes:

The AWS console does not show the available versions of the SAR app for the layers we have recently published. I added the CLI command this the ARN to fetch the available versions.

I also add instruction on how to find the Layern ARN after deploying the SAR App.

Unfortunately, you have first to deploy the SAR app to get the LayerVersionArn as an exported value that can be referenced in a Lambda function resource definition. You can not do this within one SAM template and deploy the app and the lambda in one go :(.

I added two options in the documentation, either way you need to deploy two times.

Reopened PR because I screw up my fork, this was previous PR #134

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2020

Codecov Report

Merging #145 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop      #145   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines          706       706           
  Branches        67        67           
=========================================
  Hits           706       706           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8da0cce...e1c5d84. Read the comment docs.

docs/content/index.mdx Outdated Show resolved Hide resolved
@heitorlessa
Copy link
Contributor

Here's an example where I'm referencing the outputs of a SAR App within the same stack

https://github.com/aws-samples/aws-serverless-airline-booking/blob/develop/src/backend/payment/template.yaml

Trying to understand whether this is a new limitation OR how we built the App

@am29d am29d requested a review from heitorlessa August 28, 2020 15:01
Copy link
Contributor

@heitorlessa heitorlessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes, Alex :)

There's a minor piece in the example, since that's now using both the Layer and requirements.

It needs a more elaborate fix there, so I'll merge as-is, and we can deal with that later

@heitorlessa heitorlessa merged commit 319c363 into aws-powertools:develop Aug 29, 2020
@heitorlessa heitorlessa added the documentation Improvements or additions to documentation label Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants