feat(docs): Move docs to S3 #2277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Thulbourn <sthulb@users.noreply.github.com>
sthulb
added
documentation
pull-request-size
bot
added
the
size/S
boring-cyborg
bot
added
the
github-actions
update permissions to use id-token: write to support OIDC Signed-off-by: Simon Thulbourn <sthulb@users.noreply.github.com>
pull-request-size
bot
added
size/M
add `id-token: write` Signed-off-by: Simon Thulbourn <sthulb@users.noreply.github.com>
add `id-token: write` Signed-off-by: Simon Thulbourn <sthulb@users.noreply.github.com>
leandrodamascena
requested changes
May 19, 2023
Comment on lines
+17
to
+19
| permissions: | ||
| id-token: write | ||
|
|
There was a problem hiding this comment.
Simon, we are trying to keep the permissions very granular in our worflows and I don't think this is necessary as you are adding this permission on the release-docs job. Have you tried without it?
There was a problem hiding this comment.
It seems that if you don't have id-token: write on the caller, it won't pass it down – I kept getting a id-token should be none error
There was a problem hiding this comment.
Thank you for the explanation, Simon! In the future we'll refactor this workflows and we can review this.
leandrodamascena
approved these changes
May 19, 2023
Comment on lines
+17
to
+19
| permissions: | ||
| id-token: write | ||
|
|
There was a problem hiding this comment.
Thank you for the explanation, Simon! In the future we'll refactor this workflows and we can review this.
7 tasks
github-actions
bot
added
the
pending-release
|
This is now released under 2.16.1 version! |
github-actions
bot
removed
the
pending-release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Summary
As the project changes, we want to host our documentation on our own domain, this frees us of GitHub Pages and related outages. After this change our docs will be hosted in two locations GH Pages and on docs.powertools.aws.dev, this is a middle step for further changes later.
Changes
This pull request adds some extra steps to the release docs process, it copies the generated docs to an S3 bucket.
User experience
Docs will be available in S3 and GH Pages
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.