feat(parser): add support for parsing SQS events wrapped in Kinesis Firehose #2294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leandrodamascena
requested review from
rubenfonseca
and removed request for
a team
boring-cyborg
bot
added
documentation
pull-request-size
bot
added
the
size/M
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #2294 +/- ##
========================================
Coverage 97.46% 97.47%
========================================
Files 149 150 +1
Lines 6901 6922 +21
Branches 509 509
========================================
+ Hits 6726 6747 +21
Misses 137 137
Partials 38 38
☔ View full report in Codecov by Sentry. |
|
Looking at this now |
|
|
||
| @validator("data", pre=True, allow_reuse=True) | ||
| def data_base64_decode(cls, value): | ||
| # Firehose payload is encoded twice |
There was a problem hiding this comment.
Ruben, I will validate this one more time before merging. But scare me too.
rubenfonseca
approved these changes
May 23, 2023
Ruben, your comment confused me about this and I investigated again. I was using the wrong event coming from EventBridge and indeed it's encoded once and not twice. Sorry about that, now it's ok! |
heitorlessa
added a commit
to heitorlessa/aws-lambda-powertools-python
that referenced
this pull request
May 26, 2023
* develop: chore(deps-dev): bump aws-cdk from 2.80.0 to 2.81.0 (aws-powertools#2332) chore(deps-dev): bump coverage from 7.2.5 to 7.2.6 (aws-powertools#2326) chore(deps-dev): bump pytest-cov from 4.0.0 to 4.1.0 (aws-powertools#2327) chore(deps): bump actions/setup-python from 4.6.0 to 4.6.1 (aws-powertools#2325) fix(docs): use concrete secrets from settings (aws-powertools#2322) fix(logger): add setLevel function to set level programmatically (aws-powertools#2320) feat(parser): add support for parsing SQS events wrapped in Kinesis Firehose (aws-powertools#2294)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #2293
Summary
Changes
In this update, we enhance the parser to handle SQS events that are wrapped in Kinesis Firehose.
User experience
With this new Model, you can easily extract relevant information from SQS events within the Kinesis Firehose ecosystem.
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.