Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(general): Add missing tests for parser #232

Merged
merged 1 commit into from
Dec 4, 2020

Conversation

michaelbrewer
Copy link
Contributor

@michaelbrewer michaelbrewer commented Dec 4, 2020

Issue #, if available:

Description of changes:

Changes:

  • Add missing fail case for cloudwatch parsing
  • Add more test data for decoding s3 object keys
  • Update data_classes test to include the new event json examples
  • Fix class naming to be CamelCase

Checklist

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Changes:
* Add missing fail case for cloudwatch parsing
* Add more test data for decoding s3 object keys
* Update data_classes test to include the new event json examples
* Fix class naming to be CamelCase
@codecov-io
Copy link

Codecov Report

Merging #232 (058e2bb) into develop (b9ec28d) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #232      +/-   ##
===========================================
+ Coverage    99.81%   99.89%   +0.07%     
===========================================
  Files           76       76              
  Lines         2764     2744      -20     
  Branches       111      111              
===========================================
- Hits          2759     2741      -18     
+ Misses           5        3       -2     
Impacted Files Coverage Δ
aws_lambda_powertools/logging/logger.py 100.00% <0.00%> (ø)
aws_lambda_powertools/tracing/tracer.py 100.00% <0.00%> (ø)
aws_lambda_powertools/metrics/metrics.py 100.00% <0.00%> (ø)
aws_lambda_powertools/logging/formatter.py 100.00% <0.00%> (ø)
aws_lambda_powertools/utilities/batch/base.py 100.00% <0.00%> (ø)
...ws_lambda_powertools/middleware_factory/factory.py 100.00% <0.00%> (ø)
...mbda_powertools/utilities/parser/models/kinesis.py 100.00% <0.00%> (ø)
...ertools/utilities/validation/jmespath_functions.py 100.00% <0.00%> (ø)
...a_powertools/utilities/parser/models/cloudwatch.py 100.00% <0.00%> (+6.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9ec28d...058e2bb. Read the comment docs.

Copy link
Contributor

@heitorlessa heitorlessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Michael, for taking this extra time to improve maintainability.

Much appreciated!

@heitorlessa heitorlessa merged commit 2c03d54 into aws-powertools:develop Dec 4, 2020
@michaelbrewer michaelbrewer deleted the add-missing-tests branch December 4, 2020 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants