Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unnecessary typing-extensions for py3.8 #281

Merged
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion aws_lambda_powertools/utilities/parser/models/dynamodb.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
from typing import Any, Dict, List, Optional

from pydantic import BaseModel
from typing_extensions import Literal

from ..types import Literal


class DynamoDBStreamChangedRecordModel(BaseModel):
Expand Down
3 changes: 2 additions & 1 deletion aws_lambda_powertools/utilities/parser/models/kinesis.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@

from pydantic import BaseModel, validator
from pydantic.types import PositiveInt
from typing_extensions import Literal

from ..types import Literal

logger = logging.getLogger(__name__)

Expand Down
3 changes: 2 additions & 1 deletion aws_lambda_powertools/utilities/parser/models/s3.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
from pydantic.fields import Field
from pydantic.networks import IPvAnyNetwork
from pydantic.types import PositiveInt
from typing_extensions import Literal

from ..types import Literal


class S3EventRecordGlacierRestoreEventData(BaseModel):
Expand Down
3 changes: 2 additions & 1 deletion aws_lambda_powertools/utilities/parser/models/ses.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
from pydantic import BaseModel, Field
from pydantic.networks import EmailStr
from pydantic.types import PositiveInt
from typing_extensions import Literal

from ..types import Literal


class SesReceiptVerdict(BaseModel):
Expand Down
3 changes: 2 additions & 1 deletion aws_lambda_powertools/utilities/parser/models/sns.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@

from pydantic import BaseModel, root_validator
from pydantic.networks import HttpUrl
from typing_extensions import Literal

from ..types import Literal


class SnsMsgAttributeModel(BaseModel):
Expand Down
3 changes: 2 additions & 1 deletion aws_lambda_powertools/utilities/parser/models/sqs.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
from typing import Dict, List, Optional

from pydantic import BaseModel
from typing_extensions import Literal

from ..types import Literal


class SqsAttributesModel(BaseModel):
Expand Down
7 changes: 7 additions & 0 deletions aws_lambda_powertools/utilities/parser/types.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
"""Generics and other shared types used across parser"""

from typing import TypeVar

from pydantic import BaseModel

# We only need typing_extensions for python versions <3.8
try:
from typing import Literal # noqa: F401
except ImportError:
from typing_extensions import Literal # noqa: F401

Model = TypeVar("Model", bound=BaseModel)
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ boto3 = "^1.12"
jmespath = "^0.10.0"
pydantic = {version = "^1.6.0", optional = true }
email-validator = {version = "*", optional = true }
typing_extensions = {version = "^3.7.4.2", optional = true }
typing_extensions = {version = "^3.7.4.2", optional = true, python= "<3.8" }

[tool.poetry.dev-dependencies]
coverage = {extras = ["toml"], version = "^5.0.3"}
Expand Down
2 changes: 1 addition & 1 deletion tests/functional/parser/schemas.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
from typing import Dict, List, Optional

from pydantic import BaseModel
from typing_extensions import Literal

from aws_lambda_powertools.utilities.parser.models import (
DynamoDBStreamChangedRecordModel,
Expand All @@ -14,6 +13,7 @@
SqsModel,
SqsRecordModel,
)
from aws_lambda_powertools.utilities.parser.types import Literal


class MyDynamoBusiness(BaseModel):
Expand Down