Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): temporarily disable E2E parallelism #3484

Conversation

heitorlessa
Copy link
Contributor

Issue number: #3463

Summary

This PR temporarily disables parallelism to gain release confidence all tests pass. It will add ~18 extra minutes for each run until we investigate deeply.

After merging 35fb001, E2E tests stopped working consistently. While they pass most tests, they never completed successfully anymore.

It almost looks like a packaging issue since that PR had to change to the latest manylinux distro for C-extension wheels.

 jsii.errors.JavaScriptError: 
  Error: ENOENT: no such file or directory, lstat '/home/runner/work/powertools-lambda-python/powertools-lambda-python/cdk.out/layer_build/python/pydantic/sttOUWvt'
      at Object.lstatSync (node:fs:1514:3)
      at _processFileOrDirectory (/tmp/jsii-kernel-jftarp/node_modules/aws-cdk-lib/core/lib/fs/fingerprint.js:2:1093)
      at _processFileOrDirectory (/tmp/jsii-kernel-jftarp/node_modules/aws-cdk-lib/core/lib/fs/fingerprint.js:2:1685)
      at _processFileOrDirectory (/tmp/jsii-kernel-jftarp/node_modules/aws-cdk-lib/core/lib/fs/fingerprint.js:2:1685)
      at _processFileOrDirectory (/tmp/jsii-kernel-jftarp/node_modules/aws-cdk-lib/core/lib/fs/fingerprint.js:2:1685)
      at fingerprint (/tmp/jsii-kernel-jftarp/node_modules/aws-cdk-lib/core/lib/fs/fingerprint.js:2:870)
      at Function.fingerprint (/tmp/jsii-kernel-jftarp/node_modules/aws-cdk-lib/core/lib/fs/index.js:1:2771)
      at AssetStaging.calculateHash (/tmp/jsii-kernel-jftarp/node_modules/aws-cdk-lib/core/lib/asset-staging.js:2:1396)
      at AssetStaging.stageByCopying (/tmp/jsii-kernel-jftarp/node_modules/aws-cdk-lib/core/lib/asset-staging.js:1:3881)
      at stageThisAsset (/tmp/jsii-kernel-jftarp/node_modules/aws-cdk-lib/core/lib/asset-staging.js:1:2788)

Changes

  • Use pytest tests/e2e to run all tests serially instead of parallel_run.py
  • Upgrade to nodejs 20.x to remove CDK deprecation warnings from logs

Please provide a summary of what's being changed

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@heitorlessa heitorlessa requested a review from a team as a code owner December 11, 2023 15:24
@boring-cyborg boring-cyborg bot added github-actions Pull requests that update Github_actions code internal Maintenance changes labels Dec 11, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 11, 2023
Makefile Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Dec 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.0% 3.0% Duplication

@leandrodamascena leandrodamascena merged commit 69b8a36 into aws-powertools:develop Dec 11, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github-actions Pull requests that update Github_actions code internal Maintenance changes size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants