fix(ci): fail dispatch analytics job when Lambda call fails #3579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
the
github-actions
pull-request-size
bot
added
the
size/S
rubenfonseca
had a problem deploying
to
analytics
GitHub Actions
Failure
rubenfonseca
had a problem deploying
to
analytics
GitHub Actions
Failure
rubenfonseca
had a problem deploying
to
analytics
GitHub Actions
Failure
rubenfonseca
had a problem deploying
to
analytics
GitHub Actions
Failure
rubenfonseca
had a problem deploying
to
analytics
GitHub Actions
Failure
rubenfonseca
had a problem deploying
to
analytics
GitHub Actions
Failure
|
leandrodamascena
approved these changes
Jan 2, 2024
rubenfonseca
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #3578
Summary
Changes
This PR changes the Dispatch Analytics workflow to fail the job if the Lambda invocation fails.
User experience
After this PR, we should see the job failing when the Analytics Lambda function fails.
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.