Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(data-masking): fix and improve e2e tests for DataMasking #3695

Merged
merged 3 commits into from Feb 2, 2024

Conversation

leandrodamascena
Copy link
Contributor

Issue number: #3694

Summary

Changes

After merging the DataMasking utility, we noticed some persistent issues with e2e tests failing. We took the opportunity to improve some tests.

User experience

There is no change in the user experience.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@leandrodamascena leandrodamascena requested a review from a team as a code owner February 1, 2024 22:25
@boring-cyborg boring-cyborg bot added the tests label Feb 1, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 1, 2024
@leandrodamascena leandrodamascena linked an issue Feb 1, 2024 that may be closed by this pull request
2 tasks
@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2024

Codecov Report

Attention: 42 lines in your changes are missing coverage. Please review.

Comparison is base (7d88b54) 95.65% compared to head (acc57bc) 95.58%.
Report is 7 commits behind head on develop.

Files Patch % Lines
...es/data_masking/provider/kms/aws_encryption_sdk.py 55.55% 32 Missing ⚠️
aws_lambda_powertools/shared/functions.py 37.50% 5 Missing ⚠️
...ls/event_handler/middlewares/openapi_validation.py 85.71% 2 Missing ⚠️
.../utilities/data_classes/api_gateway_proxy_event.py 84.61% 1 Missing and 1 partial ⚠️
...lambda_powertools/utilities/data_classes/common.py 66.66% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3695      +/-   ##
===========================================
- Coverage    95.65%   95.58%   -0.08%     
===========================================
  Files          214      215       +1     
  Lines        10031    10140     +109     
  Branches      1840     1867      +27     
===========================================
+ Hits          9595     9692      +97     
- Misses         326      339      +13     
+ Partials       110      109       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leandrodamascena leandrodamascena added the data-masking Sensitive Data Masking feature label Feb 1, 2024
Copy link

sonarcloud bot commented Feb 2, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@leandrodamascena leandrodamascena merged commit 94c588e into aws-powertools:develop Feb 2, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data-masking Sensitive Data Masking feature size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: fix and improve e2e tests for Data Masking utility
5 participants