Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): enable Redis e2e tests #3718

Merged

Conversation

leandrodamascena
Copy link
Contributor

@leandrodamascena leandrodamascena commented Feb 6, 2024

Issue number: #3717

Summary

Changes

We dropped Python 3.7 support in #3638, so we can now update the AWS CDK library to a version that supports the CfnServerlessCache constructor.

This will add about 6 extra minutes to each run.

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@boring-cyborg boring-cyborg bot added dependencies Pull requests that update a dependency file tests labels Feb 6, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 6, 2024
Copy link

sonarcloud bot commented Feb 6, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@leandrodamascena leandrodamascena marked this pull request as ready for review February 6, 2024 15:12
@leandrodamascena leandrodamascena requested a review from a team as a code owner February 6, 2024 15:12
@heitorlessa
Copy link
Contributor

thank you @leandrodamascena ! Changed the body slightly so it links to Py3.7 PR w/ the changes too. merging

@heitorlessa heitorlessa merged commit ada8156 into aws-powertools:develop Feb 6, 2024
24 checks passed
heitorlessa added a commit to heitorlessa/aws-lambda-powertools-python that referenced this pull request Feb 7, 2024
* develop: (21 commits)
  chore: cleanup, add test for single and nested
  fix(parameters): make cache aware of single vs multiple calls
  docs: Add nathan hanks post community (aws-powertools#3727)
  chore(deps-dev): bump isort from 5.11.5 to 5.13.2 (aws-powertools#3723)
  chore(deps-dev): bump cfn-lint from 0.83.8 to 0.85.0 (aws-powertools#3724)
  chore(deps): bump actions/download-artifact from 4.1.1 to 4.1.2 (aws-powertools#3725)
  chore(deps-dev): bump types-python-dateutil from 2.8.19.14 to 2.8.19.20240106 (aws-powertools#3720)
  chore(ci): enable Redis e2e tests (aws-powertools#3718)
  chore(deps-dev): bump pytest from 7.4.4 to 8.0.0 (aws-powertools#3711)
  chore(deps): bump actions/upload-artifact from 3.1.3 to 4.3.1 (aws-powertools#3714)
  chore(ci): changelog rebuild (aws-powertools#3715)
  chore(deps-dev): bump mypy from 1.4.1 to 1.8.0 (aws-powertools#3710)
  chore(deps-dev): bump httpx from 0.24.1 to 0.26.0 (aws-powertools#3712)
  chore(deps): bump actions/download-artifact from 3.0.2 to 4.1.1 (aws-powertools#3612)
  chore(deps): bump codecov/codecov-action from 3.1.6 to 4.0.1 (aws-powertools#3700)
  chore(deps-dev): bump coverage from 7.2.7 to 7.4.1 (aws-powertools#3713)
  chore(deps-dev): bump the boto-typing group with 7 updates (aws-powertools#3709)
  chore(deps): bump squidfunk/mkdocs-material from `a4a2029` to `e0d6c67` in /docs (aws-powertools#3708)
  chore(deps): bump release-drafter/release-drafter from 5.25.0 to 6.0.0 (aws-powertools#3699)
  chore(ci): drop support for Python 3.7 (aws-powertools#3638)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants