Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(event-handler): swagger schema respects api stage #3796

Merged
merged 2 commits into from Feb 19, 2024

Conversation

rubenfonseca
Copy link
Contributor

@rubenfonseca rubenfonseca commented Feb 19, 2024

Issue number: #3793

Summary

Changes

Please provide a summary of what's being changed

This PR fixes the path to the downloadable OpenAPI schema inside Swagger by taking into account the current API stage (if present).

User experience

Please share what the user experience looks like before and after this change

Users should be able to download the OpenAPI swagger when using API REST Gateway.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 19, 2024
@boring-cyborg boring-cyborg bot added the tests label Feb 19, 2024
Copy link
Contributor

No related issues found. Please ensure there is an open issue related to this change to avoid significant delays or closure.

@github-actions github-actions bot added do-not-merge need-issue PRs that are missing related issues labels Feb 19, 2024
@rubenfonseca rubenfonseca removed do-not-merge need-issue PRs that are missing related issues labels Feb 19, 2024
@rubenfonseca rubenfonseca marked this pull request as ready for review February 19, 2024 13:30
@rubenfonseca rubenfonseca requested a review from a team as a code owner February 19, 2024 13:30
@rubenfonseca rubenfonseca marked this pull request as draft February 19, 2024 13:32
@rubenfonseca rubenfonseca removed the request for review from heitorlessa February 19, 2024 13:40
@rubenfonseca rubenfonseca marked this pull request as ready for review February 19, 2024 13:46
@rubenfonseca rubenfonseca linked an issue Feb 19, 2024 that may be closed by this pull request
Copy link

sonarcloud bot commented Feb 19, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@heitorlessa heitorlessa merged commit 72b1fba into develop Feb 19, 2024
15 checks passed
@heitorlessa heitorlessa deleted the rf/fix-swagger-schema-url branch February 19, 2024 13:50
@heitorlessa heitorlessa added the bug Something isn't working label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working event_handlers size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Swagger generated UI has JSON format invalid URL
2 participants