chore(ci): remove aws-encryption-sdk from Lambda layer due to cffi being tied to python version #3853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
dependencies
pull-request-size
bot
added
the
size/XS
github-actions
bot
removed
the
documentation
heitorlessa
requested changes
Feb 26, 2024
boring-cyborg
bot
added
the
documentation
github-actions
bot
removed
the
documentation
boring-cyborg
bot
added
the
documentation
pull-request-size
bot
added
size/S
heitorlessa
approved these changes
Feb 26, 2024
|
github-actions
bot
removed
the
documentation
heitorlessa
changed the title
boring-cyborg
bot
added
the
documentation
github-actions
bot
removed
the
documentation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #3853 +/- ##
===========================================
+ Coverage 96.38% 96.42% +0.04%
===========================================
Files 214 214
Lines 10030 10102 +72
Branches 1846 1866 +20
===========================================
+ Hits 9667 9741 +74
+ Misses 259 258 -1
+ Partials 104 103 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #3852
Summary
Changes
We previously added the
aws-encryption-sdkto our Lambda layer, but this caused issues since the SDK requires thecryptographylibrary be installed for each specific Python runtime version (3.8 to 3.12). To resolve this, we have removed the SDK from the Lambda layer for now.User experience
Users must install the
aws-encryption-sdkand appropriate encryption library as dependencies in their projects based on their Python runtime until we find a way to provide version-specific layer builds.Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.