Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(params): expose high level max_age, raise_on_transform_error #567

Merged
merged 1 commit into from
Jul 30, 2021

Conversation

michaelbrewer
Copy link
Contributor

@michaelbrewer michaelbrewer commented Jul 27, 2021

Issue #, if available:

Description of changes:

Expose the following parameters at the top level interface:

  • max_age
  • raise_on_transform_error

Checklist

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 27, 2021
@michaelbrewer
Copy link
Contributor Author

@heitorlessa i found max_age and raise_on_transform_error.

I would have been nice if had the some config idea as idempotent handler, but probably to late for that now.

@codecov-commenter
Copy link

Codecov Report

Merging #567 (f7518cd) into develop (1135314) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #567   +/-   ##
========================================
  Coverage    99.86%   99.86%           
========================================
  Files          113      113           
  Lines         4485     4485           
  Branches       243      243           
========================================
  Hits          4479     4479           
  Misses           3        3           
  Partials         3        3           
Impacted Files Coverage Δ
...ambda_powertools/utilities/parameters/appconfig.py 100.00% <100.00%> (ø)
..._lambda_powertools/utilities/parameters/secrets.py 100.00% <100.00%> (ø)
aws_lambda_powertools/utilities/parameters/ssm.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1135314...f7518cd. Read the comment docs.

@heitorlessa heitorlessa added the feature New feature or functionality label Jul 30, 2021
@heitorlessa heitorlessa changed the title feat(params): expose max_age and other parameters feat(params): expose max_age, raise_on_transform_error as high level params Jul 30, 2021
Copy link
Contributor

@heitorlessa heitorlessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot Mike!!

@heitorlessa heitorlessa added this to the 1.19.0 milestone Jul 30, 2021
@heitorlessa heitorlessa changed the title feat(params): expose max_age, raise_on_transform_error as high level params feat(params): expose high level max_age, raise_on_transform_error Jul 30, 2021
@heitorlessa heitorlessa merged commit dfe42b1 into aws-powertools:develop Jul 30, 2021
@michaelbrewer michaelbrewer deleted the feat-params-options branch July 30, 2021 09:54
heitorlessa added a commit that referenced this pull request Jul 30, 2021
* develop:
  feat(params): expose high level max_age, raise_on_transform_error (#567)
  fix(parser): apigw wss validation check_message_id; housekeeping (#553)
  chore(deps-dev): bump isort from 5.9.2 to 5.9.3 (#574)
  feat(data-classes): decode json_body if based64 encoded (#560)
  chore(deps-dev): bump mkdocs-material from 7.2.0 to 7.2.1 (#566)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or functionality size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants