improv: Better namespace/dimension handling for Metrics #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
June 7, 2020 11:08
Use service name for default dimension instead of namespace Add namespace parameter
to-mc
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #62 +/- ##
========================================
Coverage 99.39% 99.39%
========================================
Files 15 15
Lines 492 496 +4
Branches 44 45 +1
========================================
+ Hits 489 493 +4
Misses 3 3
Continue to review full report at Codecov.
|
heitorlessa
requested changes
Jun 7, 2020
heitorlessa
approved these changes
Jun 7, 2020
6 tasks
heitorlessa
added a commit
that referenced
this pull request
Jun 10, 2020
* develop: (31 commits) docs: fix contrast on highlighted code text (#73) feat: improve error handling for log_metrics decorator (#71) chore(deps): bump graphql-playground-html from 1.6.19 to 1.6.25 in /docs feat: add high level imports (#70) fix: correct env var name for publish to pypi test (#69) chore: version bump (#68) feat: add capture_cold_start_metric for log_metrics (#67) chore(deps): bump websocket-extensions from 0.1.3 to 0.1.4 in /docs (#66) feat: automate publishing to pypi (#58) feat: add pre-commit hooks (#64) improv: include example tests in `make tests` (#63) chore: rename Makefile target docs-dev to docs-local (#65) improv: better namespace/dimension handling for Metrics (#62) docs: build on master only chore: correct docstring for log_metrics chore: fix typo in metrics doc chore: Correct test comment chore: remove unused import chore: formatting feat: update Metrics interface to resemble tracer & logger: use "service" as its namespace. ...
heitorlessa
referenced
this pull request
in heitorlessa/aws-lambda-powertools-python
Jun 17, 2020
* improv: namespace/dimension changes Use service name for default dimension instead of namespace Add namespace parameter * docs: document changes to namespace/service * chore: fix typo in docstring * chore: fix typo in docs * chore: fix test comments * chore: Add env var for namespace back into example app * chore: correct typo in docs * chore: update example in README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #61
Description of changes:
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.