docs(apigateway): fix sample layout provided #864
Conversation
Current version does not work when deployed
pull-request-size
bot
added
the
size/M
boring-cyborg
bot
added
the
documentation
Codecov Report
@@ Coverage Diff @@
## develop #864 +/- ##
========================================
Coverage 99.90% 99.90%
========================================
Files 118 118
Lines 5125 5125
Branches 283 283
========================================
Hits 5120 5120
Misses 2 2
Partials 3 3 Continue to review full report at Codecov.
|
| @@ -1073,6 +1072,8 @@ This sample project contains an Users function with two distinct set of routes, | |||
| MemorySize: 512 | |||
| Runtime: python3.9 | |||
| Tracing: Active | |||
| Architectures: | |||
| - arm64 | |||
There was a problem hiding this comment.
We build Layer for x86 only atm
There was a problem hiding this comment.
making it x86_64 for now :)
| . | ||
| ├── Pipfile # project app & dev dependencies; poetry, pipenv, etc. | ||
| ├── Pipfile # project app & dev dependencies; poetry, pipenv, etc. |
There was a problem hiding this comment.
Shall we update to poetry pyproject.tomo since we're gonna update the sample cookiecutter already?
There was a problem hiding this comment.
@heitorlessa - currently I like Pipefile as this is the default for SAM cli and Amplify templates. However I am cool to switch to Poetry
There was a problem hiding this comment.
So let's keep as-is until we migrate others.
|
Thanks a lot for helping revert to the previous sample |
|
But it works. ;-)
|
|
This is what puzzles me hahaha
…On Thu, 2 Dec 2021 at 07:08, Michael Brewer ***@***.***> wrote:
But it works. ;-)
One minor change as we don't build w Lambda Layer for ARM yet, and one
question
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#864 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZPQBHV4HMIRCARMVUAF5DUO4EN3ANCNFSM5JFU24JQ>
.
|
|
On a more serious note though, Tracer uses X-Ray SDK which depends on wrapt that uses C bindings. Unless wrapt is giving a wheel for all platforms - like Pydantic - instead of the platform in question, then in theory Tracer shouldn't work. All else should work as we don't depend on C bindings but pure Python. |
|
@heitorlessa - updated. |
heitorlessa
changed the title
Current version does not work when deployed
Issue #, if available:
Description of changes:
Fixes the sample layout for multiple file project
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
View rendered docs/core/event_handler/api_gateway.md