Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: make layer-publisher part of the main npm workspace #1226

Closed
1 of 2 tasks
dreamorosi opened this issue Jan 11, 2023 · 3 comments · Fixed by #1292
Closed
1 of 2 tasks

Maintenance: make layer-publisher part of the main npm workspace #1226

dreamorosi opened this issue Jan 11, 2023 · 3 comments · Fixed by #1292
Assignees
Labels
automation This item relates to automation completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Milestone

Comments

@dreamorosi
Copy link
Contributor

dreamorosi commented Jan 11, 2023

Summary

The layer-publisher folder contains the utilities and tests used to publish AWS Lambda Layers for Powertools. When this was developed, it was developed in isolation and with its own dependency tree. Now that the component is somewhat stable, and the dependencies of the main npm workspace has been recently updated, we can bring the folder in the npm workspace so that the dependencies are shared.

Why is this needed?

Because if the two dependency trees are not aligned we risk incurring in the issue described in #1227 every time one of the two trees change. Both trees depend on aws-cdk-lib which has a weekly release cadence so, while the issue is now fixed, it's likely it'll happen again.

Additionally, by having the layer-publisher in the main npm workspace we can decrease the project's footprint on development & CI hosts (because of sharing dependencies) and also simplify some of the workflow that are now disjointed.

Which area does this relate to?

Automation, Other

Solution

No response

Acknowledgment

@dreamorosi dreamorosi added internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) confirmed The scope is clear, ready for implementation labels Jan 11, 2023
@dreamorosi dreamorosi added this to the Lambda layer milestone Jan 11, 2023
@dreamorosi dreamorosi added the automation This item relates to automation label Jan 11, 2023
@dreamorosi
Copy link
Contributor Author

While addressing this issue, also try removing the hardcoded CDK version from this workflow.

@dreamorosi
Copy link
Contributor Author

Also remove this other hardcoded version in this other workflow.

@github-actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added the pending-release This item has been merged and will be released soon label Feb 20, 2023
@dreamorosi dreamorosi added completed This item is complete and has been merged/shipped and removed pending-release This item has been merged and will be released soon confirmed The scope is clear, ready for implementation labels Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant