This repository has been archived by the owner on May 15, 2020. It is now read-only.
Coach 0.11 #3
Merged
Coach 0.11 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use Coach Slim 0.11 from pypi - Reduce the number of transition stored in memory to 10^5 - Remove older version of Coach
This will make the simulation fail if the RL nodes fail.
x77a1
requested review from
jamesiri and
samuelgundry
and removed request for
jamesiri
samuelgundry
approved these changes
Dec 20, 2018
|
Thanks Sam. Good point, I have added it to the current commit. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Move to latest version of Coach
Consume Coach from PyPi
Limiting transition memory to 10^5
Make RL nodes required so that the job fails if they fail
Expected Impact
Reduction in memory usage
Simulation Jobs will fail if RL nodes fail