-
Notifications
You must be signed in to change notification settings - Fork 9
Allow user to automatically delete CloudWatch logs in batch that are > 14 days old #56
Conversation
Signed-off-by: Jesse Ikawa <jikawa@amazon.com>
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
==========================================
+ Coverage 82.48% 82.64% +0.15%
==========================================
Files 57 57
Lines 2398 2420 +22
==========================================
+ Hits 1978 2000 +22
Misses 420 420
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Jesse Ikawa <jikawa@amazon.com>
8ed5672
to
9bcaf27
Compare
Signed-off-by: Jesse Ikawa <jikawa@amazon.com>
9bcaf27
to
456d388
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the changes in the CloudWatch Logs specific parts are fine, but I'm not sure how this affects CloudWatch Metrics.
file_management/include/file_management/file_upload/file_manager_strategy.h
Outdated
Show resolved
Hide resolved
6109759
to
64bd082
Compare
Signed-off-by: Jesse Ikawa <jikawa@amazon.com>
64bd082
to
5bfb8ef
Compare
file_management/include/file_management/file_upload/file_manager_strategy.h
Outdated
Show resolved
Hide resolved
file_management/include/file_management/file_upload/file_manager.h
Outdated
Show resolved
Hide resolved
cloudwatch_logs_common/include/cloudwatch_logs_common/utils/log_file_manager.h
Outdated
Show resolved
Hide resolved
cloudwatch_logs_common/include/cloudwatch_logs_common/utils/log_file_manager.h
Outdated
Show resolved
Hide resolved
5ea3729
to
df4748f
Compare
file_management/include/file_management/file_upload/file_manager.h
Outdated
Show resolved
Hide resolved
3d75033
to
f19bb70
Compare
f19bb70
to
6bc65b0
Compare
Signed-off-by: Jesse Ikawa <jikawa@amazon.com>
6bc65b0
to
da7ebc6
Compare
Signed-off-by: Jesse Ikawa <jikawa@amazon.com>
Signed-off-by: Jesse Ikawa <jikawa@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes but otherwise it looks good.
Signed-off-by: Jesse Ikawa <jikawa@amazon.com>
Closes #54
AWS PutLogEvents will not upload a batch log if the logs in the batch are older than 14 days. Therefore we will allow the user to specify an option in FileManagerStrategy to automatically delete 14 day old logs from the batch.
In an effort to minimize runtime, we will first upload the correctly batched logs before deleting any remaining logs over 14 days old.
Related PR opened in cloudwatchlogs-ros1 to allow user to set delete_stale_data option in FileManagerStrategyOptions:
Add option for FileManagerStrategy delete stale data #64
Signed-off-by: Jesse Ikawa jikawa@amazon.com
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.