Use Origin Access Control #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swap from Origin Access Identity to Origin Access Control Issue #63
svozza
reviewed
Aug 9, 2023
templates/cloudfront-site.yaml
Outdated
| CloudFrontOriginAccessIdentityConfig: | ||
| Comment: !Sub 'CloudFront OAI for ${SubDomain}.${DomainName}' | ||
| OriginAccessControlConfig: | ||
| Name: !Sub 'oac-${AWS::StackName}' |
There was a problem hiding this comment.
Nice, this name needing to be unique account-wide caught me out before.
There was a problem hiding this comment.
You may want to include the region as well, since the OAC Name is global but stack names are scoped to a region. You can see an example of where this was a problem in awslabs/amazon-s3-find-and-forget@efc6889
I know this sample is currently authored to only support deploys in us-east-1, so the benefit would mostly be if that support was ever expanded, or for anyone cribbing/copying it as an example to their own templates.
There was a problem hiding this comment.
Good idea. I've added that.
svozza
approved these changes
Aug 9, 2023
The OAC name is unique across all regions in an account. A stackname is not unique across all regions in an account. Combining with the region overcomes this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#63
Description of changes:
Update CloudFront from using Origin Access Identity to Origin Access Control.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.