-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mentioning AMI in the docs #1
Comments
Hello @unfor19, I appreciate your interest in the tool. Correct, in the previous version AMI was hard-coded and you had to edit the code as you did. The good news is that I've just commited a new version which automatically select the last Amazon Linux AMI based on the region configured in your AWS CLI config. Please check it out! Absolutely, it would be very nice to have the IAM role creation automated, feel free to send me a PR. Could you please elaborate more on the use case to have this wrapped in a Docker image? I mean, are you considering to run it using a runtime like Fargate, ECS or EKS instead of EC2? If so, how would the script manage it? PS: This new version also includes a new feature (cmd) that allows you to execute any command you want. Thanks! |
Hey @tgpadua
Here's how I usually wrap a Bash script as a CLI - https://github.com/unfor19/bargs |
Thank you for this tool, it works as expected.
Other than creating the IAM role, I think it would be great to add something about the AMI, or maybe even allow providing it as an environment variable. I edited the code and hardcoded the AMI for eu-west-1.
Also, would you be interested in a PR that wraps it up in a Docker image? I can also add a script for creating the SSMInstanceProfile IAM role (and policy).
The text was updated successfully, but these errors were encountered: