Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Converted ES6 import to require #125

Merged
merged 1 commit into from
Feb 19, 2020
Merged

Conversation

ravanapel
Copy link
Contributor

Fixes #124


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mergify
Copy link
Contributor

mergify bot commented Feb 18, 2020

"### Pull Request Checklist * [ ] Testing - Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change) * [ ] Title and Description - Change type: title prefixed with fix, feat and module name in parens, which will appear in changelog - Title: use lower-case and doesn't end with a period - Breaking?: last paragraph: 'BREAKING CHANGE: <describe what changed + link for details>' - Issues: Indicate issues fixed via: 'Fixes #xxx' or 'Closes #xxx'"

@mergify
Copy link
Contributor

mergify bot commented Feb 18, 2020

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@mergify
Copy link
Contributor

mergify bot commented Feb 18, 2020

"### Pull Request Checklist * [ ] Testing - Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change) * [ ] Title and Description - Change type: title prefixed with fix, feat and module name in parens, which will appear in changelog - Title: use lower-case and doesn't end with a period - Breaking?: last paragraph: 'BREAKING CHANGE: <describe what changed + link for details>' - Issues: Indicate issues fixed via: 'Fixes #xxx' or 'Closes #xxx'"

@mergify
Copy link
Contributor

mergify bot commented Feb 18, 2020

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@ravanapel ravanapel changed the title Converted ES6 import to require fix: Converted ES6 import to require Feb 18, 2020
Copy link
Contributor

@NGL321 NGL321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! LGTM

😸

@mergify
Copy link
Contributor

mergify bot commented Feb 19, 2020

Thank you for contributing! Your pull request is now being automatically merged.

@mergify mergify bot merged commit 6c3fa70 into aws-samples:master Feb 19, 2020
@HusseinMorsy
Copy link

I just noticed that the fix has not yet been deployed on the website.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with CdkWorkshop typescript
3 participants