cid-cfn.yml: Add validation on CFN parameter S3 bucket path #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iakov-aws
reviewed
Aug 30, 2023
iakov-aws
reviewed
Aug 30, 2023
iakov-aws
approved these changes
Sep 21, 2023
iakov-aws
approved these changes
Sep 21, 2023
|
Merged! Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Issue: Forgetting to put s3:// prefix OptimizationDataCollectionBucketPath would cost time to debug as the CFN stack deployed successfully but QuickSight dataset is empty due to the Athena table was not created.
This PR copies the validation from https://github.com/aws-samples/aws-cudos-framework-deployment/blob/main/cfn-templates/cid-cfn.yml#L118
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.