Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix crawler permissions #822

Merged
merged 6 commits into from
Jun 6, 2024
Merged

fix crawler permissions #822

merged 6 commits into from
Jun 6, 2024

Conversation

iakov-aws
Copy link
Collaborator

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@JoshiiSinfield
Copy link

JoshiiSinfield commented May 31, 2024

+1 hitting this. Crawler is failing as not got permissions to log out. Also had to incldue the s3:ListBucket as per this PR to fix it.

@joseluis-fw
Copy link

Yes, crawler is broken, missing permissions.

@iakov-aws
Copy link
Collaborator Author

@yprikhodko @esc1144 @vmindru please can you approve this? looks like we need to publish this fix asap.

@iakov-aws
Copy link
Collaborator Author

@joseluis-fw @JoshiiSinfield was it CFN or TF install where you saw the issue?

@joseluis-fw
Copy link

joseluis-fw commented Jun 6, 2024

@iakov-aws I am using the terraform setup for the dashboard, but it's only a wrapper for that cloudformation template.

this is the snippet:

module "cid_dashboards" {
    source = "github.com/aws-samples/aws-cudos-framework-deployment//terraform-modules/cid-dashboards"

    stack_name      = "Cloud-Intelligence-Dashboards"
    template_bucket = aws_s3_bucket.this.id

    stack_parameters = {
      "CURBucketPath" = "s3://cid-${data.aws_caller_identity.current.account_id}-shared/cur/${var.aws_master_account_id}/cid-cur/cid-cur/"
      "PrerequisitesQuickSight"            = "yes"
      "PrerequisitesQuickSightPermissions" = "yes"
      "QuickSightUser"                     = "AWSReservedSSO_Admin_xxxx/wadus@tradus.com"
      "DeployCUDOSDashboard"               = "yes"
      "DeployCostIntelligenceDashboard"    = "yes"
      "DeployKPIDashboard"                 = "yes"
    }
}

@iakov-aws iakov-aws merged commit 2cc6a9c into main Jun 6, 2024
17 checks passed
@iakov-aws iakov-aws deleted the fix-crawler-permissions branch June 6, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants