-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor sdlf-ddk-lightweight #15
refactor sdlf-ddk-lightweight #15
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work, thanks for the cleanup and additions here! Haven't tested a deployment yet but will try that now.
sdlf-ddk-lightweight/data_lake/pipelines/standard_pipeline/standard_dataset_stack.py
Show resolved
Hide resolved
...tweight/data_lake/src/glue/pyshell_scripts/sdlf_heavy_transform/demoteam/legislators/main.py
Show resolved
Hide resolved
sdlf-ddk-lightweight/data_lake/src/lambdas/sdlf_heavy_transform/routing/handler.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! Thank you very much for the refactoring. Added a few minor comments & clarifications
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a couple of nitpicky comments but overall this looks great! Awesome work
sdlf-ddk-lightweight/data_lake/pipelines/common_stages/sdlf_light_transform.py
Outdated
Show resolved
Hide resolved
- use _environment_id from parent class - only grant start execution to our state machine
I have tested the most recent version end-to-end and everything works. |
Description of changes:
sdlf_pipeline_stack
->sdlf_base_stack
,sdlf_dataset_stack
->standard_dataset_stack
sdlf_pipeline_stack
into a subfolderpipelines/standard_pipeline/standard_pipeline.py
also movedsdlf_dataset_stack.py
into this folder and renamed as mentioned above.sdlf_heavy_transform.py
andsdlf_light_transform.py
topipelines/common_stages/...
foundations
folderCustomPipeline
andCustomDataset
as an example of how customers can add custom pipelines.SDLFPipeline
protocol (interface)parameters.json
to have aconfig
element for pipeline specific configuration to support custom pipelines.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.