Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: docs are using old architecture diagram without appsync #329

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

Rob-Powell
Copy link
Contributor

Issue #, if available:

Description of changes:
When moving to vitepress docs updated image with appsync commit was replaced with the original api gateway diagram, this corrects that with the proper image.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Collaborator

@massi-ang massi-ang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The resolution of the 2 files is not the same. Any issue with that?

@Rob-Powell
Copy link
Contributor Author

The resolution of the 2 files is not the same. Any issue with that?

I just put back the same image size you originally committed with your changes @massi-ang. the docs site simply references the image, the new size won't cause any issues, aside from it being slightly smaller.

@bigadsoleiman bigadsoleiman merged commit 329d7e8 into aws-samples:main Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants