feat(sagemaker models): use Generative AI CDK constructs for SageMaker model deployment #343
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
lib/models/index.ts
to consume the constructsHow was this tested ?
Used
npm create
to enable all models available from the list and run a request for each one of them through the UI, see images below:Notes:
I wasn't able at first to test the IDEFICS models as I was facing an error when running cdk deploy with those models enabled:
I Had to create an IAM role with apigateway.amazonaws.com as its trusted entity, attach the managed policy
AmazonAPIGatewayPushToCloudWatchLogs
to the IAM role, and set the IAM role ARN on the cloudWatchRoleArn property of my account. Haven't seen that step mentioned in the documentation.Questions:
@bigadsoleiman @spugachev
scripts/get-model-packages
? Seems this is not necessary anymoresagemaker-model/README.md
) to reflect the changes above ?By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.