Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for more flexible streaming options #642

Merged
merged 2 commits into from Mar 25, 2024

Conversation

atjohns
Copy link
Contributor

@atjohns atjohns commented Mar 19, 2024

This update is designed to make streaming more flexible in scenarios where the bot is handling both streaming and non-streaming conversations. Turning streaming on at the Web UI will now trigger session attributes containing the dynamo table and API Gateway endpoint information, so fulfillment Lambdas can look for those parameters and decide whether the response needs to be streamed.

Other small changes

  • Bring the Web UI up to speed on Node/NPM versions
  • Change the browser targets for webpack.
  • Make the copy function/icon a toggle controlled by a config property and center it to align with the feedback buttons.

@atjohns atjohns merged commit 8078809 into development Mar 25, 2024
@t-jones
Copy link
Contributor

t-jones commented Mar 28, 2024

Austin, would it be possible to get a couple changes? In templates/codebuild-deploy.yaml:

  • The output parameter name on 1306 is incorrect.
  • Could we get the whole api gateway web socket url as an output?

Thanks!

@atjohns
Copy link
Contributor Author

atjohns commented Mar 28, 2024

Hey @t-jones, yes I can fix that typo. the outputs here actually don't really matter anymore now that its all being passed to the config directly and the UI is passing that back to the bot. I think they could probably just be deleted unless you have a use case for needing them?

@t-jones
Copy link
Contributor

t-jones commented Mar 28, 2024

the outputs here actually don't really matter anymore now that its all being passed to the config directly and the UI is passing that back to the bot. I think they could probably just be deleted unless you have a use case for needing them?

@atjohns you are correct. Thanks for reminding me part of the point of what you are doing is to support N clients. We'll get this from the session as you show in the example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants