Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IAM role in Outputs when using Serverless Application #7

Closed
jogold opened this issue Jan 17, 2019 · 6 comments
Closed

Add IAM role in Outputs when using Serverless Application #7

jogold opened this issue Jan 17, 2019 · 6 comments
Labels
enhancement New feature or request

Comments

@jogold
Copy link

jogold commented Jan 17, 2019

Hello,

Multi user strategies require access to a master secret.

When deploying the strategy with the AWS Serverless Repository the only way I see to allow this is to add in my CF template a resource policy on the master secret allowing the role created by the Serverless Application to call GetSecretValue. Since this role is not outputed, I cannot find a way to achieve this.

@StevenEmelander
Copy link

Thank you for this request, this is a good change that we had not previously looked at. We will investigate making this change for a future release.

@willtong1234 willtong1234 added the enhancement New feature or request label Jan 18, 2019
@jogold
Copy link
Author

jogold commented Jan 19, 2019

Another solution would be to take the arn of the master secret as a property in your Serverless Application and use it inside to construct a correct policy.

@jogold
Copy link
Author

jogold commented Mar 18, 2019

Hello, any update on this?

It would be great to be able to create multi user rotation strategies with CloudFormation...

@jogold
Copy link
Author

jogold commented Aug 28, 2019

@StevenEmelander @willtong1234 any update?

@willtong1234
Copy link
Contributor

I apologize for the delay in this. We have investigated the feasibility of outputting the IAM role from our templates. Unfortunately, since we simply leverage the AWS::Serverless::Function SAM resource (see https://github.com/awslabs/serverless-application-model/blob/master/versions/2016-10-31.md#awsserverlessfunction), we do not have the IAM role in the output in order to output from our own template. The only output available is the ARN of the lambda itself, which we already output. In order to get the role ARN, we would first have to get the role ARN output from SAM. You will probably need to submit an issue to them here: https://github.com/awslabs/serverless-application-model/issues.

@rstevens011
Copy link

I am closing this issue as this is a limitation of SAM. Please re-open if you have any questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants