adjust vpc flow log creation logic (#1112)

aws-samples · Mar 9, 2023 · b5dc19c · b5dc19c
1 parent 055c6a8
commit b5dc19c
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/deployments/cdk/src/deployments/vpc/step-2.ts b/src/deployments/cdk/src/deployments/vpc/step-2.ts
@@ -156,13 +156,14 @@ function createVpcFlowLog(props: {
     customFields,
   } = props;
   for (const [index, logDestination] of logDestinations.entries()) {
-    const flowLogs = new ec2.CfnFlowLog(scope, `FlowLog${vpcName}${logDestinationTypes[index]}`, {
-      deliverLogsPermissionArn: roleArn,
+    const logDestinationType = logDestinationTypes[index];
+    const flowLogs = new ec2.CfnFlowLog(scope, `FlowLog${vpcName}${logDestinationType}`, {
+      deliverLogsPermissionArn: logDestinationType == ec2.FlowLogDestinationType.CLOUD_WATCH_LOGS ? roleArn : undefined,
       resourceId: vpcId,
       resourceType: 'VPC',
       trafficType,
       logDestination,
-      logDestinationType: logDestinationTypes[index],
+      logDestinationType: logDestinationType,
     });
     flowLogs.addPropertyOverride('MaxAggregationInterval', aggregationInterval);
     if (customFields) {