Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: namespace refactoring #38

Merged
merged 6 commits into from
May 13, 2024
Merged

feat: namespace refactoring #38

merged 6 commits into from
May 13, 2024

Conversation

sliedig
Copy link
Contributor

@sliedig sliedig commented Jan 22, 2024

Issue number:
#37

Summary

Separated namespace definitions. These only need to be defined once per domain/sub-domain and don't need to be replaced across environments like other resources.

Changes

  • Separated namespace parameter store definitions into a separate template. This needs to be deployed before any applications
  • Added Makefiles for self hosted workshops to deploy and teardown infra for namespaces and images buckets.
  • Updated all the templates in the solution to reference "{{resolve:ssm:/uni-prop/UnicornContractsNamespace}}" instead of Fn::Sub: "{{resolve:ssm:/uni-prop/${Stage}/UnicornContractsNamespace}}"
  • Updated nest template definitions with explicit Update/Delete policies
  • Minor fixes and spelling corrections

User experience

Simplified management and referencing of namespace parameters

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@sliedig sliedig requested a review from a team as a code owner January 22, 2024 15:50
@github-actions github-actions bot added the feature New features or minor changes label Jan 22, 2024
Copy link
Contributor

@sankeyraut sankeyraut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@sankeyraut sankeyraut merged commit 851b603 into develop May 13, 2024
5 checks passed
@sliedig sliedig deleted the sliedig-ns-refactor branch May 14, 2024 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New features or minor changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants